ARO-3258: propagate errors of ARO PullSecret controller to ARO operator #3947
+39
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbossis
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
@microsoft-github-policy-service agree company="Red Hat" |
pkg/operator/controllers/pullsecret/pullsecret_controller_test.go
Outdated
Show resolved
Hide resolved
| @@ -285,11 +287,11 @@ func TestPullSecretReconciler(t *testing.T) { | |||
| ctx := context.Background() | |||
|
|
|||
| clientFake := ctrlfake.NewClientBuilder().WithObjects(tt.instance).WithObjects(tt.secrets...).Build() | |||
| assert.NotNil(t, clientFake) | |||
There was a problem hiding this comment.
Do we need to add these extra assert calls here? The test works as-is without them added.
There was a problem hiding this comment.
It should be helpful to manifest nil object occurrence whenever that object is supposed to be not nil and thus to render test case failure early on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-3258
What this PR does / why we need it:
It is needed to propagate errors of ARO PullSecret controller to ARO operator in order to see those errors at the Operator level and to see all the controller errors in one place.
Test plan for issue:
[x] Unit Test Cases
[x] Local Cluster Creation
[] CI
[] E2E
Are there unit tests
Yes, https://github.com/Azure/ARO-RP/blob/master/pkg/operator/controllers/pullsecret/pullsecret_controller_test.go
How do you know this will function as expected in production?
Running all unit tests locally and verifying tests output
Is there any documentation that needs to be updated for this PR?
N/A