Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for Feature #537: Simplify workflow names in Accelerator #578

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Jul 18, 2023

Overview/Summary

#537
AB#29749

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Updates pipeline/workflow names to provide more clarity as to what they do and to make them easier to reference.

Breaking Changes

  1. Won't break existing deployments, but did require changes to the ALZ PowerShell Module

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

@oZakari
Copy link
Contributor Author

oZakari commented Jul 18, 2023

Hey @MilesCameron-DMs, how do these file names work? The only thing I really changed was just keeping the number there to make it easier to show what order they generally need to use for a new deployment.

If so, would you be able to update the pictures/diagrams you created and create a PR against my branch? You can also create a separate PR if that is easier for you. Whatever works :)

@oZakari oZakari self-assigned this Jul 18, 2023
@oZakari oZakari changed the title Simplify names PR for Feature #537: Simplify workflow names in Accelerator Jul 18, 2023
@oZakari oZakari marked this pull request as draft July 18, 2023 05:07
@MilesCameron-DMs MilesCameron-DMs mentioned this pull request Jul 18, 2023
10 tasks
@MilesCameron-DMs
Copy link
Contributor

Thanks @oZakari - i have submitted a separate PR: #579

That was a little easier for me than submitting a PR against your fork/branch.

Any issues let me know 😉

@oZakari oZakari marked this pull request as ready for review July 20, 2023 18:19
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit e594962 into Azure:main Jul 21, 2023
4 checks passed
@oZakari oZakari deleted the simplify-names branch July 28, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants