Ensure Azure Storage Account default network access is set to Deny

[Acenl12]

Restricting default network access helps to provide an additional layer of security. By default, storage accounts accept connections from clients on any network. To limit access to selected networks, the default action must be changed.

[jtracey93]

Hey @Acenl12,

Thanks for the PR.

This is a change to an internal function we use to help us cleanup subscriptions once they've been used in a PR. This isn't something we expect customers to use and is not part of the ALZ architecture.

Can I ask for some background and context to this change. Are you using this function?

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

[Acenl12]

Hey @Acenl12,

Thanks for the PR.

This is a change to an internal function we use to help us cleanup subscriptions once they've been used in a PR. This isn't something we expect customers to use and is not part of the ALZ architecture.

Can I ask for some background and context to this change. Are you using this function?

I think you guys need to lead by example and not expose insecure configs in GitHub

[jikuja]

Hey @Acenl12,
Thanks for the PR.
This is a change to an internal function we use to help us cleanup subscriptions once they've been used in a PR. This isn't something we expect customers to use and is not part of the ALZ architecture.
Can I ask for some background and context to this change. Are you using this function?

I think you guys need to lead by example and not expose insecure configs in GitHub

Did you test if function app still works after applying this change?

[oZakari]

Hi @Acenl12, we are using the free tier for Azure functions which does not have VNet integration or private endpoint capabilities. We also cannot deny public access and only allow Azure services for the storage account as Azure Functions are currently not classified under the trusted services list.

As @jtracey93, the resources within this configuration are only used for an internal test/sandbox subscription and are not to related to the functionality/design of ALZ or the underlying modules within this repository.