feat: creating an SMT verification module #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumata888
reviewed
Aug 30, 2023
| @@ -187,6 +193,99 @@ template <typename Arithmetization> class CircuitBuilderBase { | |||
| real_variable_tags.emplace_back(DUMMY_TAG); | |||
| return index; | |||
| } | |||
|
|
|||
| /** | |||
| * Assign a name to a variable(equivalence calss). Should be one name per equivalence class. | |||
| msgpack::sbuffer buffer; | ||
| msgpack::pack(buffer, cir); | ||
| return buffer; | ||
| // info("Buffer size: ", buffer.size()); |
| barretenberg_module(smt_verification common ${CMAKE_SOURCE_DIR}/src/cvc5/tmp-lib/lib/libcvc5.so.1) | ||
|
|
||
| barretenberg_module(smt_examples common proof_system stdlib_primitives smt_verification) | ||
| #barretenberg_module(smt_polynomials common proof_system stdlib_primitives smt_verification) |
|
|
||
| 1. First you need to import the circuit from the saved file or from the buffer: | ||
|
|
||
| - `smt_circuit::CircuitSchema c_info = smt_circuit::unpack_from_file(str fname);` |
There was a problem hiding this comment.
Can you provide instructions without storing the circuit on disk?
| @@ -0,0 +1,111 @@ | |||
| # TODO how exactly ref works | |||
| import cvc5 | |||
There was a problem hiding this comment.
This file is not documented at all
| #include "circuit.hpp" | ||
| namespace smt_circuit { | ||
|
|
||
| Circuit::Circuit(CircuitSchema& circuit_info, Solver* solver, const std::string& tag) |
There was a problem hiding this comment.
This file has very few comments
|
This became a monorepo PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
@briefdescribing the intended functionality.includedirectives have been added.