Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineNumbersMargin property added to TextEditor #402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NickRimmer
Copy link

Hey, community (;

I want to suggest a tiny update, to be able to set margins for line numbers.

@Numpsy
Copy link

Numpsy commented Mar 19, 2024

I can't really comment on the usefulness of the API, but maybe it could have the same change as in #405 to use GetBindingObservable instead of new Binding ?

@NickRimmer
Copy link
Author

NickRimmer commented Mar 24, 2024

I can't really comment on the usefulness of the API, but maybe it could have the same change as in #405 to use GetBindingObservable instead of new Binding ?

@Numpsy Absolutely agree. Will push updated soon. Thank you (;

@NickRimmer
Copy link
Author

My changes rebased to latest AvaloniaEdit master with suggested fixes

@danipen danipen requested a review from Gillibald March 29, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants