Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP REST API Integration #137

Merged
merged 7 commits into from
Sep 13, 2017
Merged

WP REST API Integration #137

merged 7 commits into from
Sep 13, 2017

Conversation

MattGeri
Copy link

  • Adds new REST class for WP REST API support
  • Adds tests for different methods

This leaves the old REST implementation intact. The new endpoint configuration is called "REST Push Client (New)"

@philipjohn The only piece that is missing here is the actual authentication layer. On my local, I used https://wp-oauth.com/ but the actual WordPress.com implementation will be different. In the configuration, it lets you paste the Auth token for now if you want to test.

* Add new REST class for WP REST API support
* New post method working
* Fixing comments
* Edit post now working
* New post inteceptor working
* Tests passing
* Add test for syncing taxonomies
* Add edit, delete and taxonomy sync tests
* Fix interceptor to work with multiple requests
@philipjohn
Copy link
Contributor

Mentioning #116 which this PR deals with.

@philipjohn philipjohn added this to the v2.1 milestone Jul 31, 2017
@philipjohn
Copy link
Contributor

Some feedback on this;

  • When creating a "REST Push Client" endpoint, the text "To generate the following information automatically please visit the settings page" includes a broken link, and the actual Syndication settings page contains no instructions on how to set that up.
  • "REST Push Client" is the WordPress.com REST service, but that isn't clear, which adds to the confusion.
  • There are two REST Push clients, with different options and it's again unclear what each is and whether they should be used.
  • Did you look into the "XML Pull" service which is no longer present in the 2.1 branch?
  • Have you looked at migration given the identifiers for the endpoints has changed in the 2.1 branch?

@MattGeri
Copy link
Author

Hi @philipjohn

I'll need your direction here on how to position the two different REST API push clients (one is the WP REST API and the other the WordPress.com API). Last time we spoke on Slack you mentioned there is no authentication layer setup on WordPress.com yet for the WP REST API and you were going to look at getting one setup so that we can complete the integration (and the setup process). You also mentioned we should leave the WordPress.com API intact. Let me know if you have different/new thoughts regarding this.

With regards to the XML Pull service, what specifically would you like me to look at? Does it need to be ported to version 2.1?

Thanks,
Matt

@philipjohn philipjohn merged commit 708261f into Automattic:2.1 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants