[Project] Manage Downloaded Episodes - Display Modal when running on low storage and turn on Auto Download

[mebarbosa]

Description

• Displays the low storage modal when running on low storage and turn on Auto Download
• This PR does not implement the snooze for 7 days feature when taping on Maybe Later button
• See: VvERCFIopLjFL8Fnczsf8r-fi-123_1167
• Context: p1730298732804909/1730291928.354409-slack-C07TL9YK9V1

Fixes #3150

Testing Instructions

Modify the code bellow to always return true to make the tests faster. This will mock the low storage check

pocket-casts-android/modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/StorageUtil.kt

Line 11 in 565d4f7

suspend fun isDeviceRunningOnLowStorage(statFs: StatFs = StatFs(Environment.getExternalStorageDirectory().path)): Boolean = withContext(Dispatchers.IO) {

1. Download an episode
2. Go to Profile -> Auto Download
3. Turn on New Episodes toggle
4. ✅ Ensure the modal opens

Screenshots or Screencast

Screen_recording_20241101_133738.webm

Checklist

• If this is a user-facing change, I have added an entry in CHANGELOG.md
• Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
• I have considered whether it makes sense to add tests for my changes
• All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
• Any jetpack compose components I added or changed are covered by compose previews
• I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

• with different themes
• with a landscape orientation
• with the device set to have a large display and font size
• for accessibility with TalkBack

[wpmobilebot]

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.

	App Name	📱 Mobile
	Build Type	debugProd
	Commit	022d930
	Direct Download	pocketcasts-app-prototype-build-pr3151-022d930.apk

📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.

	App Name	🚗 Automotive
	Build Type	debugProd
	Commit	022d930
	Direct Download	pocketcasts-automotive-prototype-build-pr3151-022d930.apk

📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.

	App Name	⌚ Wear
	Build Type	debugProd
	Commit	022d930
	Direct Download	pocketcasts-wear-prototype-build-pr3151-022d930.apk

[geekygecko]

This is a question for my knowledge, are we meant to update this file?

[MiSikora]

Sometimes we need to regenerate it. Like in this case where onAttach() got reported incorrectly by Lint. However, due to GH Lint integration we need to un-comment this line first.

pocket-casts-android/build.gradle.kts

Lines 193 to 194 in 435a262

	// Uncomment this when regenerating baseline files
	// ignoreWarnings = true

[MiSikora]

In 5497a6b isDeviceRunningOnLowStorage() got changed to use Dispatcher.IO but can you update it to something like this?

--- suspend fun isDeviceRunningOnLowStorage(statFs: StatFs = StatFs(Environment.getExternalStorageDirectory().path)): Boolean = withContext(Dispatchers.IO) {
+++ suspend fun isDeviceRunningOnLowStorage(file: File = Environment.getExternalStorageDirectory()): Boolean = withContext(Dispatchers.IO) {
+++    val statFs = StatFs(file.path)

The expensive part isn't reading all the properties of the StatFs object but creating it because this is what calls statvfs(2).

[mebarbosa]

suspend fun isDeviceRunningOnLowStorage(file: File = Environment.getExternalStorageDirectory()): Boolean = withContext(Dispatchers.IO) {
val statFs = StatFs(file.path)

@MiSikora I am struggling to make this change because it breaks the unit tests https://github.com/Automattic/pocket-casts-android/blob/main/modules/services/utils/src/test/java/au/com/shiftyjelly/pocketcasts/utils/StorageUtilTest.kt

I can not inject a mock after this.