Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Playback Settings - Analytics #3136

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Custom Playback Settings - Analytics #3136

merged 4 commits into from
Nov 1, 2024

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Oct 30, 2024

Description

This updates analytics for playback effects settings.

Part of: #3042

Testing Instructions

Events with FF Off

  • Run the app and make sure the custom_playback_settings FF is off
  • Open the player full screen and tap the Effects to prompt the sheet
  • Enable/Disable the trim silence
  • Event 🔵 Tracked: playback_effect_trim_silence_toggled ["enabled": SELECTED_VALUE, "source": "player_playback_effects", "content_type": "audio"]
  • Change the value of the Trim Silence
  • Event 🔵 Tracked: playback_effect_trim_silence_amount_changed ["content_type": "audio", "source": "player_playback_effects", "amount": SELECTED_VALUE]
  • Enable/Disable the Volume Boost
  • Event 🔵 Tracked: playback_effect_volume_boost_toggled ["enabled": SELECTED_VALUE, "content_type": "audio", "source": "player_playback_effects"]
  • Change the playback speed and dismiss the screen
  • Event 🔵 Tracked: playback_effect_speed_changed ["content_type": "audio", "source": "player_playback_effects", "speed": SELECTED_VALUE]

Events with FF On

Note: with the FF on, the new property settings could be global or local

  • Run the app and make sure the FF is on
  • Open the player full screen and tap the Effects to prompt the sheet
  • Event 🔵 Tracked: playback_effect_settings_view_appeared ["source": "player_playback_effects", "content_type": "audio", "settings": YOUR_VALUE]
  • Change tapping the segmented to apply the global or local settings
  • Event 🔵 Tracked: playback_effect_settings_changed ["source": "player_playback_effects", "settings": YOUR_VALUE, "content_type": "audio"]
  • Event 🔵 Tracked: playback_effect_trim_silence_toggled ["enabled": SELECTED_VALUE, "source": "player_playback_effects", "content_type": "audio", "settings": YOUR_VALUE]
  • Change the value of the Trim Silence
  • Event 🔵 Tracked: playback_effect_trim_silence_amount_changed ["content_type": "audio", "source": "player_playback_effects", "amount": SELECTED_VALUE, "settings": YOUR_VALUE]
  • Enable/Disable the Volume Boost
  • Event 🔵 Tracked: playback_effect_volume_boost_toggled ["enabled": SELECTED_VALUE, "content_type": "audio", "source": "player_playback_effects", "settings": YOUR_VALUE]
  • Change the playback speed: with the FF on we use a debouncer to track the event
  • Event: 🔵 Tracked: playback_effect_speed_changed ["speed": 1.5, "settings": "local", "content_type": "audio", "source": "player_playback_effects", "settings": YOUR_VALUE]

Podcast Settings

  • Navigate to the podcast settings -> Playback Effects -> Enable Custom for this podcast.
  • Do the same test with the FF on/off when Enable Custom for this podcast is on
  • If the FF is on the event contains the property settings
  • Events are the same as above

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the Future milestone Oct 30, 2024
@ashiagr ashiagr requested a review from a team as a code owner October 30, 2024 12:45
@ashiagr ashiagr requested review from mebarbosa and removed request for a team October 30, 2024 12:45
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 30, 2024

2 Warnings
⚠️ Class Debouncer is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class Work is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 30, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitb3be3c1
Direct Downloadpocketcasts-app-prototype-build-pr3136-b3be3c1.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitb3be3c1
Direct Downloadpocketcasts-automotive-prototype-build-pr3136-b3be3c1.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitb3be3c1
Direct Downloadpocketcasts-wear-prototype-build-pr3136-b3be3c1.apk

Copy link
Contributor

@mebarbosa mebarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

Base automatically changed from task/3042-update-distinct-condition to main November 1, 2024 04:18
@ashiagr ashiagr merged commit f89ff78 into main Nov 1, 2024
19 of 22 checks passed
@ashiagr ashiagr deleted the task/3042-analytics branch November 1, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants