-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Playback Settings - Analytics #3136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashiagr
added
[Type] Feature
Adding a new feature.
do not merge
[Project] Custom Playback Settings
labels
Oct 30, 2024
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
mebarbosa
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates analytics for playback effects settings.
Part of: #3042
Testing Instructions
Events with FF Off
custom_playback_settings
FF is off🔵 Tracked: playback_effect_trim_silence_toggled ["enabled": SELECTED_VALUE, "source": "player_playback_effects", "content_type": "audio"]
🔵 Tracked: playback_effect_trim_silence_amount_changed ["content_type": "audio", "source": "player_playback_effects", "amount": SELECTED_VALUE]
🔵 Tracked: playback_effect_volume_boost_toggled ["enabled": SELECTED_VALUE, "content_type": "audio", "source": "player_playback_effects"]
🔵 Tracked: playback_effect_speed_changed ["content_type": "audio", "source": "player_playback_effects", "speed": SELECTED_VALUE]
Events with FF On
Note: with the FF on, the new property
settings
could beglobal
orlocal
🔵 Tracked: playback_effect_settings_view_appeared ["source": "player_playback_effects", "content_type": "audio", "settings": YOUR_VALUE]
🔵 Tracked: playback_effect_settings_changed ["source": "player_playback_effects", "settings": YOUR_VALUE, "content_type": "audio"]
🔵 Tracked: playback_effect_trim_silence_toggled ["enabled": SELECTED_VALUE, "source": "player_playback_effects", "content_type": "audio", "settings": YOUR_VALUE]
🔵 Tracked: playback_effect_trim_silence_amount_changed ["content_type": "audio", "source": "player_playback_effects", "amount": SELECTED_VALUE, "settings": YOUR_VALUE]
🔵 Tracked: playback_effect_volume_boost_toggled ["enabled": SELECTED_VALUE, "content_type": "audio", "source": "player_playback_effects", "settings": YOUR_VALUE]
🔵 Tracked: playback_effect_speed_changed ["speed": 1.5, "settings": "local", "content_type": "audio", "source": "player_playback_effects", "settings": YOUR_VALUE]
Podcast Settings
podcast settings -> Playback Effects -> Enable Custom for this podcast
.Enable Custom for this podcast
is onsettings
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...