Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Manage Downloaded Episodes - Reduce bottom padding under “Manage downloads” #3135

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Oct 30, 2024

Description

  • The Manage Downloads had extra bottom padding. I am removing this padding due this feedback: p1730045912253859/1729890721.860929-slack-C07TL9YK9V1
  • The TextButton already has padding, that's why I don't need extra padding for this button coming from parent

Fixes #3117

Testing Instructions

  1. Ensure the device has less than 10% storage available (or adjust lowStorageThreshold in StorageUtilTest.kt to simplify testing; it’s currently set to 10%).
  2. Enable the Manage Downloaded Episodes feature flag.
  3. Download a few episodes.
  4. Navigate to Profile > Downloads.
  5. ✅ Verify that Mange downloads from the banner has bottom padding reduced

Screenshots or Screencast

image

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added this to the 7.77 milestone Oct 30, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner October 30, 2024 12:26
@mebarbosa mebarbosa requested review from geekygecko and removed request for a team October 30, 2024 12:26
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 30, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitfee1b3f
Direct Downloadpocketcasts-app-prototype-build-pr3135-fee1b3f.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitfee1b3f
Direct Downloadpocketcasts-automotive-prototype-build-pr3135-fee1b3f.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitfee1b3f
Direct Downloadpocketcasts-wear-prototype-build-pr3135-fee1b3f.apk

@geekygecko
Copy link
Member

It's separate from this PR, but I noticed the exported pencil_cleanup.xml asset is 25dp by 24dp, and the Compose image is size(24.dp). Is it worth checking with the designers to see why it's not exporting at the correct size?

<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="25dp"
    android:height="24dp"
    android:viewportWidth="25"
    android:viewportHeight="24">

@geekygecko geekygecko merged commit 65d0b72 into main Oct 31, 2024
17 of 19 checks passed
@geekygecko geekygecko deleted the task/update-low-storage-card-padding branch October 31, 2024 03:54
@mebarbosa
Copy link
Contributor Author

It's separate from this PR, but I noticed the exported pencil_cleanup.xml asset is 25dp by 24dp, and the Compose image is size(24.dp). Is it worth checking with the designers to see why it's not exporting at the correct size?

<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="25dp"
    android:height="24dp"
    android:viewportWidth="25"
    android:viewportHeight="24">

@geekygecko I've created a slack thread for it: p1730378068922729-slack-C05RR9P9RAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Manage Downloaded Episodes - Reduce bottom padding under “Manage downloads”
3 participants