Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Up Next Shuffle - Update Shuffle Button Visibility #3134

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Oct 30, 2024

Description

  • Update the shuffle button visibility. It will be visible only when the up next is not empty
  • Context: p1730257991386309/1730230283.156089-slack-C07T08CTND9

Fixes #3089

Testing Instructions

  1. Have the shuffle feature flag on
  2. Play an episode and have up next empty
  3. Tap on Up next tap
  4. ✅ Ensure you don't see the shuffle button
  5. Add episodes to up next
  6. Open Up next
  7. ✅ Ensure you see the shuffle button

Screenshots or Screencast

Free User

Screen_recording_20241030_085326.webm

Plus User

Screen_recording_20241030_085412.webm

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added this to the 7.77 milestone Oct 30, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner October 30, 2024 12:00
@mebarbosa mebarbosa requested review from MiSikora and removed request for a team October 30, 2024 12:00
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 30, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit78d0047
Direct Downloadpocketcasts-app-prototype-build-pr3134-78d0047.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit78d0047
Direct Downloadpocketcasts-automotive-prototype-build-pr3134-78d0047.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit78d0047
Direct Downloadpocketcasts-wear-prototype-build-pr3134-78d0047.apk

@mebarbosa mebarbosa merged commit defd98b into main Oct 30, 2024
17 of 18 checks passed
@mebarbosa mebarbosa deleted the update/shuffle-button-visibility branch October 30, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Up Next Shuffle - Fix visibility for Shuffle when there is no current episode in progress
3 participants