Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EoY screenshot failure logs #3133

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add EoY screenshot failure logs #3133

merged 1 commit into from
Oct 30, 2024

Conversation

MiSikora
Copy link
Contributor

Description

This PR adds logging in case of EoY screenshot creation failures to help with potential diagnosis.

Testing Instructions

Code review is enough.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@MiSikora MiSikora added [Type] Other Issues not covered by other types, such as refactoring and documentation. [Project] End of Year labels Oct 30, 2024
@MiSikora MiSikora added this to the 7.77 milestone Oct 30, 2024
@MiSikora MiSikora requested a review from a team as a code owner October 30, 2024 09:08
@MiSikora MiSikora requested review from ashiagr and removed request for a team October 30, 2024 09:08
@MiSikora MiSikora changed the title Enable EoY feature flag Add EoY screenshot failure logs Oct 30, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 30, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commita01419b
Direct Downloadpocketcasts-app-prototype-build-pr3133-a01419b.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commita01419b
Direct Downloadpocketcasts-automotive-prototype-build-pr3133-a01419b.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commita01419b
Direct Downloadpocketcasts-wear-prototype-build-pr3133-a01419b.apk

@MiSikora MiSikora merged commit fa6380c into main Oct 30, 2024
15 of 16 checks passed
@MiSikora MiSikora deleted the task/eoy-logging branch October 30, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year [Type] Other Issues not covered by other types, such as refactoring and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants