Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use landscape images in the Featured cluster #3113

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Oct 28, 2024

Description

This adds support for landscape images in the Trending cluster for Engage SDK integration.

Testing Instructions

  1. Apply this patch.
  2. Install fresh version of the app.
  3. Open the app
  4. Minimize the app.
  5. Wait a bit so that the Discover page is crawled.
  6. Proceed with the Engage integration workflow until the 3rd step.
  7. Check that the trending cluster uses landscape images.

Screenshots or Screencast

Screenshot_20241028-082408

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@MiSikora MiSikora added [Type] Enhancement Improve an existing feature. [Project] Engage SDK labels Oct 28, 2024
@MiSikora MiSikora added this to the 7.76 milestone Oct 28, 2024
@MiSikora MiSikora requested a review from a team as a code owner October 28, 2024 07:32
@MiSikora MiSikora requested review from geekygecko and removed request for a team October 28, 2024 07:32
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 28, 2024

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 28, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit62b2b78
Direct Downloadpocketcasts-app-prototype-build-pr3113-62b2b78.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit62b2b78
Direct Downloadpocketcasts-automotive-prototype-build-pr3113-62b2b78.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit62b2b78
Direct Downloadpocketcasts-wear-prototype-build-pr3113-62b2b78.apk

@MiSikora MiSikora modified the milestones: 7.76, 7.77 Oct 28, 2024
@MiSikora MiSikora changed the title Use landscape images for the Featured cluster Use landscape images in the Featured cluster Oct 28, 2024
@geekygecko geekygecko merged commit 0c378fc into main Oct 29, 2024
16 checks passed
@geekygecko geekygecko deleted the task/engage-landscape branch October 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] Engage SDK [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants