Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Post ID to msm_sitmap_skip_posts #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BrookeDot
Copy link

This PR adds $post_id to the msm_sitmap_skip_posts filter. Doing so allows for posts to be excluded by using the filter directly.

Note: this is a backward incompatible change, as it adds a second argument to the filter

Fixes #183

Adds the post ID to msm_sitmap_skip_posts

This is a backwards incompatible change, as it adds a second argument to the filter

Fixes #183
@pkevan
Copy link
Contributor

pkevan commented Aug 23, 2024

This will probably need to be tested with someone using the filter currently, as I can't find any examples!

@BrookeDot
Copy link
Author

Makes sense @pkevan the other thought I had was to support both (adding a new filter for the addition of $post_id) something like msm_sitmap_skip_posts_by_id and then fire a doing_it_wrong when the old filter is used.

Thoughts?

@pkevan
Copy link
Contributor

pkevan commented Aug 27, 2024

Probably preferable just to have one filter - in theory it shouldn't break by adding a parameter (as 1 parameter is the default for all filters), but depends on how legacy application have been calling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass $post_id to msm_sitemap_skip_post
2 participants