LOOKDEVX-2354 - Fix the transform nodes crash #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A transform node with empty space values will cause the shadergen to crash. This has been fixed in future MaterialX 1.38.9 by introducing ShaderPort::getValueString() in AcademySoftwareFoundation/MaterialX#1560 We have backported that fix in local copies of the transform node C++ implementations in order to prevent crashing with the current versions of MaterialX.
|
|
||
| string MayaTransformVectorNodeGlsl::getPortValueString(const ShaderInput* input) const | ||
| { | ||
| if (!input || !input->getValue()) { |
There was a problem hiding this comment.
This is where the crash gets fixed. The previous code was not checking for !input->getValue().
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
seando-adsk
deleted the
gamaj/LOOKDEVX-2354/fix_crash_with_transform_nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transform node with empty space values will cause the shadergen to crash. This has been fixed in future MaterialX 1.38.9 by introducing ShaderPort::getValueString() in AcademySoftwareFoundation/MaterialX#1560
We have backported that fix in local copies of the transform node C++ implementations in order to prevent crashing with the current versions of MaterialX.