Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor QR Code Export. #79

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Visitor QR Code Export. #79

merged 1 commit into from
Oct 1, 2024

Conversation

stmudie
Copy link
Member

@stmudie stmudie commented Sep 30, 2024

Visitor Pool QR code export to PDF. Refactor qr code generation to make it common.
Fixes #7

portrain
portrain approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@portrain portrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation! A future improvement could be to have the output PDF filename configurable. But since it is being streamed, not an important change.

@stmudie stmudie merged commit d2c46bb into main Oct 1, 2024
1 check passed
@stmudie stmudie deleted the sm-Visitor-QR-Code-Export branch October 1, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portrain portrain portrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visitor QR Code Export
2 participants
@stmudie @portrain