Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

chore(package): update flow-bin to version 0.44.0 #163

Merged
merged 2 commits into from
Apr 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions declarations/modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,3 @@ declare module 'atom-linter' {
declare function find(filePath: string, fileName: string): ?string;
declare function exec(executable: string, args?: Array<string>, config?: Object): Promise<string>;
}

declare module 'lodash.flatten' {
declare var exports: <T>(array: Array<T | T[]>) => T[]
};
2 changes: 0 additions & 2 deletions lib/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
/* @flow */

'use babel';

// eslint-disable-next-line import/extensions
import { CompositeDisposable } from 'atom';
import path from 'path';
Expand Down
28 changes: 13 additions & 15 deletions lib/message.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
/* @flow */

'use babel';

// eslint-disable-next-line import/extensions
import { Range } from 'atom';
import flatten from 'lodash.flatten';

import type { FlowError, LinterTrace, LinterMessage } from './types';
import type { FlowError, FlowMessage, LinterTrace, LinterMessageV1 } from './types';

function extractRange(message: FlowError): Range {
function extractRange(message: FlowMessage): Range {
return new Range(
[message.line - 1, message.start - 1],
[message.endline - 1, message.end],
);
}

function flowMessageToTrace(message: FlowError): LinterTrace {
function flowMessageToTrace(message: FlowMessage): LinterTrace {
return {
type: 'Trace',
text: message.descr,
Expand All @@ -24,23 +21,24 @@ function flowMessageToTrace(message: FlowError): LinterTrace {
};
}

function flowMessageToLinterMessages({ message: flowMessages }): Array<LinterMessage> {
const blameMessages = flowMessages.filter(m => m.type === 'Blame');
function flowErrorToLinterMessages(flowError: FlowError): Array<LinterMessageV1> {
const blameMessages = flowError.message.filter((m: FlowMessage) => m.type === 'Blame');

return blameMessages.map((flowMessage, i) => ({
type: flowMessage.level === 'error' ? 'Error' : 'Warning',
text: flowMessages.map(msg => msg.descr).join(' '),
filePath: flowMessage.path || null,
range: extractRange(flowMessage),
return blameMessages.map((message: FlowMessage, i) => ({
type: flowError.level === 'error' ? 'Error' : 'Warning',
text: flowError.message.map((msg: FlowMessage) => msg.descr).join(' '),
filePath: message.path || null,
range: extractRange(message),
trace: [...blameMessages.slice(0, i), ...blameMessages.slice(i + 1)].map(flowMessageToTrace),
}));
}

function handleData(json: any): Array<LinterMessage> {
function handleData(json: any): Array<LinterMessageV1> {
if (json.passed || !json.errors) {
return [];
}
return flatten(json.errors.map(flowMessageToLinterMessages));
return json.errors.reduce((messages, error) =>
messages.concat(flowErrorToLinterMessages(error)), []);
}

export default handleData;
34 changes: 27 additions & 7 deletions lib/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export type LinterTrace = {
range?: Range;
};

export type LinterMessage = {
export type LinterMessageV1 = {
type: 'Error' | 'Warning';
text?: string;
html?: string;
Expand All @@ -18,16 +18,36 @@ export type LinterMessage = {
trace?: Array<LinterTrace>;
};

export type FlowError = {
level: string;
export type FlowPoint = {
column: number;
line: number;
offset: number;
}

export type FlowLocation = {
end: FlowPoint;
source: string;
start: FlowPoint;
}

export type FlowMessage = {
context: string;
descr: string;
path: string;
end: number;
endline: number;
line: number;
loc?: FlowLocation;
path: string;
start: number;
endline: number;
end: number;
type: string;
};

export type FlowError = {
kind: string;
level: string;
message: Array<FlowMessage>;
}

export type BufferType = {
cachedText: string;
getText(): string;
Expand All @@ -45,5 +65,5 @@ export type Linter = {
scope: 'file' | 'project';
name?: string;
lintOnFly: boolean;
lint(TextEditor: TextEditorType): Array<LinterMessage> | Promise<Array<LinterMessage>>;
lint(TextEditor: TextEditorType): Array<LinterMessageV1> | Promise<Array<LinterMessageV1>>;
};
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
},
"dependencies": {
"atom-linter": "^10.0.0",
"atom-package-deps": "^4.0.1",
"lodash.flatten": "^4.2.0"
"atom-package-deps": "^4.0.1"
},
"package-deps": [
"linter"
Expand All @@ -34,7 +33,7 @@
"eslint": "^3.16.1",
"eslint-config-airbnb-base": "^11.1.1",
"eslint-plugin-import": "^2.0.1",
"flow-bin": "^0.42.0"
"flow-bin": "^0.44.0"
},
"eslintConfig": {
"extends": "airbnb-base",
Expand Down
6 changes: 3 additions & 3 deletions spec/linter-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('Flow provider for Linter', () => {
atom.workspace.open(constructorPath).then(editor =>
lint(editor).then((messages) => {
expect(messages.length).toBe(1);
expect(messages[0].type).toBe('Warning');
expect(messages[0].type).toBe('Error');
expect(messages[0].text).toBe(msgText);
expect(messages[0].filePath).toBe(constructorPath);
expect(messages[0].trace.length).toBe(0);
Expand All @@ -43,14 +43,14 @@ describe('Flow provider for Linter', () => {
lint(editor).then((messages) => {
expect(messages.length).toBe(2);

expect(messages[0].type).toBe('Warning');
expect(messages[0].type).toBe('Error');
expect(messages[0].text).toBe(msgText);
expect(messages[0].filePath).toBe(arrayPath);
expect(messages[0].trace.length).toBe(1);
expect(messages[0].trace[0].range).toEqual([[3, 16], [3, 22]]);
expect(messages[0].range).toEqual([[9, 4], [9, 8]]);

expect(messages[1].type).toBe('Warning');
expect(messages[1].type).toBe('Error');
expect(messages[1].text).toBe(msgText);
expect(messages[1].filePath).toBe(arrayPath);
expect(messages[1].trace.length).toBe(1);
Expand Down