Skip to content

Commit

Permalink
LibWeb/HTML: Update spec comments for "URL and history update steps"
Browse files Browse the repository at this point in the history
Corresponds to:
whatwg/html#10587
  • Loading branch information
AtkinsSJ committed Oct 31, 2024
1 parent 76e638b commit 38213df
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Userland/Libraries/LibWeb/HTML/Navigable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1932,7 +1932,6 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_
// 2. Let activeEntry be navigable's active session history entry.
auto active_entry = navigable->active_session_history_entry();

// FIXME: Spec should be updated to say "classic history api state" instead of serialized state
// 3. Let newEntry be a new session history entry, with
// URL: newURL
// serialized state: if serializedData is not null, serializedData; otherwise activeEntry's classic history API state
Expand Down Expand Up @@ -1987,6 +1986,8 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_
traversable->append_session_history_synchronous_navigation_steps(*navigable, JS::create_heap_function(document.realm().heap(), [traversable, navigable, new_entry, entry_to_replace, history_handling] {
// 1. Finalize a same-document navigation given traversable, navigable, newEntry, and entryToReplace.
finalize_a_same_document_navigation(*traversable, *navigable, new_entry, entry_to_replace, history_handling);

// 2. FIXME: Invoke WebDriver BiDi history updated with navigable.
}));
}

Expand Down

0 comments on commit 38213df

Please sign in to comment.