Adding LFGM campaign #1397
Merged
Adding LFGM campaign #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mobile
Desktop
Desktop hover
|
gtg7784
requested review from
impelcrypto,
ayumitk,
bobo-k2,
codespool and
Kahonnohak
and removed request for
impelcrypto and
ayumitk
|
Visit the preview URL for this PR (updated for commit 6758037): https://astar-apps--pr1397-lfgm-p51kvo2c.web.app (expires Mon, 21 Oct 2024 07:21:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
bobo-k2
approved these changes
Oct 14, 2024
|
@gtg7784 thanks!! |
Of course, I'll update it |
codespool
reviewed
Oct 14, 2024
| .menu__assets { | ||
| margin-top: -276px; | ||
| margin-top: calc(-276px - 120px); |
Comment on lines
+105
to
+113
| margin-top: calc(-230px - 120px); | ||
| } | ||
|
|
||
| .menu__staking { | ||
| margin-top: -184px; | ||
| margin-top: calc(-184px - 120px); | ||
| } | ||
|
|
||
| .menu__bridge { | ||
| margin-top: -138px; | ||
| margin-top: calc(-138px - 120px); |
There was a problem hiding this comment.
because there is a possibility to remove this banner in future, I thought that it's better to use calc to not calculate back again and prevent mis-calculation the values
There was a problem hiding this comment.
Since it's for documentation purpose, I'd advise using a comment instead of calc.
impelcrypto
approved these changes
Oct 14, 2024
gtg7784
added a commit
that referenced
this pull request
Oct 28, 2024
* Adding LFGM campaign (#1397) * add lfgm link to links * add lfgm asset * add lfgm image to desktop sidebar * add lfgm image to mobile nav * add target as block to open new window * hide blog section (#1399) * hide blog section * add forum to mobile nav * Remove leaderboard for voting period (#1403) * Remove leaderboard for voting period * Added empty div instead voting leaderboard to preserve vertical spacing * Delete Neurolanche from dapp_promotions.json (#1405) * Delete Neurolanche from dapp_promotions.json * Delete public/images/dapp_promotions/neurolanche.jpeg * Remove staked contracts check (#1400) * Startale link fix (#1408) * add governance link to mobile nav (#1409) --------- Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Neurolanche X Labs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Check list
This pull request makes the following changes:
Adds