Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a dApp tier rank #1363

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Display a dApp tier rank #1363

merged 3 commits into from
Aug 27, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jul 31, 2024

Pull Request Summary

dApp details page update to show the dApp tier rank
image

A dApp tier rank is number from 0 to 10 and it is used to calculate tier rewards. A dApp with a higher rank within the same tier will get more rewards than a dApp with lower rank. More info here and here

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Jul 31, 2024

Visit the preview URL for this PR (updated for commit 3fc9219):

https://astar-apps--pr1363-feat-show-dapp-rank-qjk5azw7.web.app

(expires Mon, 26 Aug 2024 08:19:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto
Copy link
Member

@bobo-k2 Why 0 for the rank of all the dApps?

@Kahonnohak
Copy link
Contributor

Thanks!
Screenshot 2024-08-01 at 13 51 32

  • Please make this card flip and add "More information about Tier and Rank please check our documentation" and link to the relevant area?

  • Can you please make ASTR small-16px? please

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Aug 16, 2024

@bobo-k2 Why 0 for the rank of all the dApps?

It is because the feature is not live on Astar and Shiden. I made this PR too early.

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Aug 19, 2024

Hi @Kahonnohak I updated the code according to your comments

@gtg7784
Copy link
Member

gtg7784 commented Aug 19, 2024

@bobo-k2 Why 0 for the rank of all the dApps?

It is because the feature is not live on Astar and Shiden. I made this PR too early.

Is it works now?

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Aug 20, 2024

Is it works now?

Yes, it works. Astar and Shiden runtimes have been upgraded
image

@bobo-k2 bobo-k2 merged commit aeefe34 into main Aug 27, 2024
8 of 9 checks passed
@bobo-k2 bobo-k2 deleted the feat/show-dapp-rank branch August 27, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants