Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to calculation contributing items #734

Merged

Conversation

paulwarren-wk
Copy link
Contributor

Reason for change

Fixes regression with link to contributing items in a calculation.

Clicking on a contributing item in the calculations section of the fact inspector gives an exception:

inspector.js:772 Uncaught TypeError: Cannot read properties of undefined (reading 'vuid')

Description of change

items changed from a property to a method, but this reference was not updated.

Steps to Test

Open a report with calculations. Click on the calculation total, then on one of the contributing items in the fact inspector. The contributing item should now be selected.

review:
@Arelle/arelle
@paulwarren-wk

@paulwarren-wk paulwarren-wk requested a review from a team as a code owner September 16, 2024 15:27
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@austinmatherne-wk austinmatherne-wk merged commit 4c88a0c into Arelle:master Sep 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants