Switch to write-excel-file for table export #525
Conversation
| data = JSON.parse(jsonString); | ||
| } | ||
| catch (e) { | ||
| return; |
There was a problem hiding this comment.
Out of curiosity, why is this needed? Does write-excel-file send messages internally to itself?
There was a problem hiding this comment.
Seemingly - something is creating 20 or so messages at the point that the file is downloaded. I couldn't immediately make sense of it, but I think it might be coming from jsZip which write-excel-file depends on.
There was a problem hiding this comment.
It would be good to add a comment explaining that we're swallowing exceptions in order to ignore messages coming from the write-excel-file dependency.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
austinmatherne-wk
force-pushed
the
write-excel-file
branch
from
375336b
to
c9c5277
Compare
austinmatherne-wk
added
the
minor-release
Reason for change
See #416 - a large part of the viewer JS file was the exceljs library.
Description of change
Replace the use of
exceljswith the much smallerwrite-excel-file. This change reduces the size of the productionixbrlviewer.jsfrom 1.8MiB to 834KiB.Steps to Test
Open a report with tables in it, and confirm that the "Export Table" output works as it did before.
review:
@Workiva/xt
@paulwarren-wk