Use javascript utils

Arelle · May 22, 2023 · 0605c83 · 0605c83
1 parent a3873bd
commit 0605c83
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -183,21 +183,11 @@ export class Fact {
     }
 
     hasExplicitDimension() {
-        for (const d in this.dimensions()) {
-            if (!this._report.getConcept(d).isTypedDimension()) {
-                return true;
-            }
-        }
-        return false;
+        return this.dimensions().some(d => !this._report.getConcept(d).isTypedDimension());
     }
 
     hasTypedDimension() {
-        for (const d in this.dimensions()) {
-            if (this._report.getConcept(d).isTypedDimension()) {
-                return true;
-            }
-        }
-        return false;
+        return this.dimensions().some(d => this._report.getConcept(d).isTypedDimension());
     }
 
     isMonetaryValue() {

diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -169,11 +169,7 @@ iXBRLReport.prototype.getIXNodeForItemId = function(id) {
 }
 
 iXBRLReport.prototype.facts = function() {
-    const allItems = [];
-    for (const id in this.data.facts) {
-        allItems.push(this.getItemById(id));
-    }
-    return allItems;
+    return this.data.facts.map(id => this.getItemById(id));
 }
 
 iXBRLReport.prototype.filingDocuments = function() {