Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: remove PosePublisher plugin from iris_with_gimbal #65

Conversation

srmainwaring
Copy link
Collaborator

@srmainwaring srmainwaring commented Sep 20, 2023

Remove the gz::sim::systems::PosePublisher to avoid publishing a duplicate set of pose frames prefixed with the model name.

Follow up to #64

Also see: ArduPilot/ardupilot_gz#32

@srmainwaring srmainwaring added the enhancement New feature or request label Sep 20, 2023
@srmainwaring srmainwaring self-assigned this Sep 20, 2023
@srmainwaring srmainwaring changed the title Copter: remove PosePublisher plugin from iris_with_gimbal Iris: remove PosePublisher plugin from iris_with_gimbal Sep 20, 2023
Copy link

@pedro-fuoco pedro-fuoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've wanted to get rid of it since I found out it doesn't follow the ROS tf tree standard.

@srmainwaring srmainwaring merged commit cb64038 into ArduPilot:ros2 Sep 21, 2023
3 checks passed
@srmainwaring srmainwaring deleted the prs/pr-iris-gimbal-remove-pose-publisher branch September 21, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants