Cpplint rules update #106
Merged
Cpplint rules update #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmainwaring
reviewed
Aug 7, 2024
|
@srmainwaring 80c change removed and socketudp updated |
srmainwaring
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
LGTM thanks @khancyr.
We're a bit inconsistent with Gazebo coding standards in places (not just in SocketUDP but some of the plugins too). For ecxample the gz-sim libraries require curly braces on a newline and a few other conventions that are different to both ROS and ArduPilot. Not a blocker for this change, but a question for followup is whether we want to use the gz-sim library linter rules and try to bring everything in line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose :
raise line to 127 as that match most 2024 standard screen
remove copyright rule to not include mess (parachute don't have it anyway)