Member self rotation #315
Open
Member self rotation #315
+1,454
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godzillaba
reviewed
Sep 30, 2024
gzeoneth
requested changes
Oct 3, 2024
godzillaba
reviewed
Oct 3, 2024
gzeoneth
approved these changes
Oct 9, 2024
Comment on lines
167
to
168
| NAME_HASH = keccak256(bytes("SecurityCouncilManager")); | ||
| VERSION_HASH = keccak256(bytes("1")); |
There was a problem hiding this comment.
these can simply be constants
There was a problem hiding this comment.
not critical, but if we change these to constant we should remember to update __gap too
There was a problem hiding this comment.
I have them as storage so that we do the same as OZ's library. Dunno if we'll ever need to change the name or version, but I guess that's why OZ do that. What dyou guys think, should I make constant?
There was a problem hiding this comment.
OZ did that because it is an upgradable contract that need to be initialized. In our case we already know what to be initialized into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.