Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propmon: retry failing retryables #314

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

godzillaba
Copy link
Collaborator

@godzillaba godzillaba commented Aug 29, 2024

Trying to execute a retryable that cannot be redeemed will crash propmon. We should probably keep this behavior so we are alerted to this.

However, some retryables are expected to not be redeemable for some period of time. This PR modifies the behavior of RetryableExecutionStage::execute to keep trying to redeem every minute if the retryable ID is in a whitelist. If the retryable is not in the list, propmon will crash as usual.

eg, add this to .env

PENDING_RETRYABLES='["0x42cdcf30aa6de466277d44efa3fef5c0ebd0ca79b2585cb8b79625451dfc4a73","0xbfac911b67e7f79a69e0e9afc329573e3b7a017c1d31e7b368f59cdcab25110a"]'

@yahgwai
Copy link
Collaborator

yahgwai commented Aug 30, 2024

Hmm, ideally propmon wouldnt crash right? We would just want it to log an error for that proposal, but keep monitoring other proposals

For retryables that we expect to fail, maybe we should have it the other way round. Ie keep retrying by default, but then have an override for retryables that we now know will always fail.

@godzillaba
Copy link
Collaborator Author

i removed the whitelist, so it'll just retry everything. i don't think we'll have retryables that never redeem, but we'll have some (like activating the cache manager after stylus activates) that need to wait a bit

so instead of being alerted to a failed retryable via propmon crashing, we'll be notified of the L1 Timelock and failed retryables will be shown in the UI as READY

Copy link
Collaborator

@yahgwai yahgwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool, we can add a whitelist if we ever get an always failing retryable

@godzillaba godzillaba merged commit be337bc into main Sep 16, 2024
7 of 8 checks passed
@godzillaba godzillaba deleted the propmon-retryable-failures branch September 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants