Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager Role Proposal Data #290

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Manager Role Proposal Data #290

wants to merge 31 commits into from
+124 −19

Conversation

godzillaba
Copy link
Collaborator

@godzillaba godzillaba commented Jun 11, 2024 •
edited
Loading 

yarn gen:proposalData --govChainProviderRPC https://arb1.arbitrum.io/rpc \
    --actionChainIds 42161 \
    --actionAddresses 0x29f3c6b8c98488FBAE0677AB3d2Eb29c77D6aD8a \
    --writeToJsonPath ./scripts/proposals/SwitchManagerRoles/SwitchManagerRoles.json \
    --nonEmergencySCproposal true

Action contract code: #284
Seatbelt: ArbitrumFoundation/governance-seatbelt#30

@godzillaba
fix overflow when aliasing
7c7b46f
@godzillaba
remove commented
17c676a
@godzillaba
remove unused offset var
4e5e6d4
@godzillaba
update forge-std to v1.8.2
99f69f1
@godzillaba
take advantage of skip cheatcode for fork test
d06b79a
@godzillaba
Merge branch 'fix-test-overflow' into update-forge-std
115b737
@godzillaba
GrantRotatorRoleToNonEmergencyCouncil
af13939
@godzillaba
use l1 timelock alias in test
bdab94b
@godzillaba
rename and cleanup
adfc064
@godzillaba
all roles
3580208
@godzillaba
rename
39b5dc2
@godzillaba
fix test
4edff8d
@godzillaba
update diagram
208fd9c
@godzillaba
update docs
6eb3867
@godzillaba
gas snapshot
fd26592
@godzillaba
Merge branch 'update-forge-std' into manager-role-action
704d543
@godzillaba
Revert "gas snapshot"
31402a4 
This reverts commit fd26592.
@godzillaba
Merge branch 'update-forge-std' into manager-role-action
92a940b
@godzillaba
use previous forge-std version
1d1c684
@godzillaba
use old fork check
43431a7
@godzillaba
gas snapshot
fb72034
@godzillaba
Merge branch 'main' into manager-role-action
2cb8230
@godzillaba
update docs
199e4f1
@godzillaba
Merge branch 'main' into manager-role-action
275b6a8
@godzillaba
prop data
d7bf332
@godzillaba
add checks in perform
7d76dec
@godzillaba
update gotchas
8a2ba80
@godzillaba
Merge branch 'manager-role-action' into manager-role-action-data
3240a71
@godzillaba
update proposal data
9561a5f
@godzillaba godzillaba mentioned this pull request Jun 13, 2024
Merged
@godzillaba godzillaba mentioned this pull request Jun 13, 2024
Merged
@godzillaba godzillaba requested a review from yahgwai June 13, 2024 15:01
fredlacs
fredlacs requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@fredlacs fredlacs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the proposal data is only reproducible if you have visibility into the github PR comment.
You could document the cli command and its args to reproduce the proposal data, but preferably make a script that generates it as in https://github.com/ArbitrumFoundation/governance/blob/b5e97139e5f9907f80d2fa34f97c8f624c8dc83d/scripts/proposals/ArbOS11AIP/generateProposalData.ts

could at least make a bash script that runs the above cli command

@fredlacs fredlacs mentioned this pull request Jun 19, 2024
Open
@godzillaba godzillaba requested a review from fredlacs June 19, 2024 20:57
Base automatically changed from manager-role-action to main July 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahgwai yahgwai yahgwai approved these changes

@fredlacs fredlacs Awaiting requested review from fredlacs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godzillaba @yahgwai @fredlacs