Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add names to tag detections #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add names to tag detections #150

wants to merge 2 commits into from

Conversation

jack-slip
Copy link
Contributor

Can be useful for hashing tag bundles for consumers of a /tag_detection stream

wxmerkt
wxmerkt reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. While I agree with the usefulness of having the names, we don't want to change messages of released packages (it would make rosbags etc. incompatible) - sorry

@jack-slip
Copy link
Contributor Author

Thank you for the PR. While I agree with the usefulness of having the names, we don't want to change messages of released packages (it would make rosbags etc. incompatible) - sorry

Understood. Would you be in favor of the default behavior being the current message structure for backwards compatibility, but have an optional param that can enable publishing of a new NamedAprilTagDetection(Array) type? Or something along those lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxmerkt wxmerkt wxmerkt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-slip @wxmerkt