Endpoint for server info #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
endpoint-for-server-info
branch
from
2eea6b9
to
e8d5b29
Compare
|
The other alternative to returning a supported feature list, would be to return the server version, and the minimum supported client version. It's not possible to do this at the moment, however, because our server package version is always |
khorshuheng
force-pushed
the
endpoint-for-server-info
branch
from
e8d5b29
to
e637865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few scenarios which it will be helpful for a client to be aware of the functionality currently supported by AppFlowy Cloud:
A user is using self hosting an older version of AppFlowy Cloud, which does not support some of the newer functionality introduced by the newer client. Having a server info endpoint will allow the client to either provide a fallback, or provide appropriate error message to the user.
A user is using an older version of AppFlowy client, which relies on functionality that is already deprecated by AppFlowy Cloud. By checking the features supported by the server, the client can prompt the user to upgrade the client version.