Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up dockerfile #16

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

sabotagebeats
Copy link
Contributor

@sabotagebeats sabotagebeats commented Jul 20, 2023

What I did

Clean up the dockerfile, and build from builder with wheels

fixes: issue where the silverback docker image does not have the newest version of silverback

How I did it

cleaned up the dockerfile using the techniques used in ape core

How to verify it

build the dockerfile

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@sabotagebeats sabotagebeats marked this pull request as ready for review July 21, 2023 03:31
antazoey
antazoey previously approved these changes Jul 21, 2023
Dockerfile Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

Have to check that this builds first

@sabotagebeats
Copy link
Contributor Author

Have to check that this builds first

It builds for me but I would love if someone else could try

docker build -t test .

@fubuloubu
Copy link
Member

fubuloubu commented Jul 21, 2023

Builds! And has the right version built:

$ docker run -it --entrypoint /bin/bash sbk-test
harambe@10cda5e23f38:~/project$ pip freeze | grep silverback
silverback==0.1.0b8.dev3+g8ad79f4

@fubuloubu fubuloubu merged commit e31bc3e into ApeWorX:main Jul 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants