test: max type was off in the test #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Sep 18, 2024
| @@ -14,8 +14,8 @@ | |||
| ({"a": 1}, {"a": {"type": "scalar", "data": 1}}), | |||
| # max INT96 value | |||
| ( | |||
| {"a": 2**96 - 1}, | |||
There was a problem hiding this comment.
You were maybe thinkin' of UInt96 here?
fubuloubu
previously approved these changes
Sep 18, 2024
fubuloubu
reviewed
Sep 18, 2024
fubuloubu
reviewed
Sep 18, 2024
| {"a": 2**96 - 1}, | ||
| {"a": {"type": "scalar", "data": 79228162514264337593543950335}}, | ||
| {"a": 2**95 - 1}, | ||
| {"a": {"type": "scalar", "data": 39614081257132168796771975167}}, | ||
| ), | ||
| # int over INT96 max parses as Decimal |
fubuloubu
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #113
How I did it
The max int for Int96 is defined as
2**95 - 1but the test was using2**96 - 1How to verify it
Checklist