my-button entity support, my-slider-v2 seekbar and more. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug on slider-v2 with switch & lock in vertical position not transitioning correct style More style changes to the button component. Again breaking changes if you use custom styling for the cards. With the new styling has come a new row/column of buttons. Readme has been updated to show config my-button has been updated to accept button, lock & no entities. my-button has been updated so there are default actions on the card for some of the entity types better config management in the code. Should not change anything for the user, except better stability maybe. Fixed bug in my-slider-v2 where card would not load state correctly changed colorMode/coverMode to just be mode. They will still work for now, but are deprecated, so you should use mode now. lock entity buttons accept the 'camera' key which is a string like 'camera.front_door'. This will show a mini livestream in the stats container which is opened on tap. label config now accept 'extra' key which is a string that will display an extra text underneath the main label styles has been updated so they can be nested in the configs they belong to.
Better helper functions thanks to the wonderful authors of the custom button-card over at https://github.com/custom-cards/button-card Better typesafety in code thanks to aboive changes.
…media_player as entity and set mode 'seekbar'
my-slider-v2 new config key 'sliderMin'. This is to determine the minimum percentage progress to show always. To be honest, I am uncertain what showMin is for? There has always been bugs loading the initial states for the different entity domains. I am trying to address these. But having a hard time finding them all. Also input_numbers using decimals have never worked in this card. I am trying to address this as well.
…ber/number entities.
my-button media_player support. It has seekbar in bottom, pause/play button in bottom left before seekbar, volume slider in right side if active and will show song title and artist under label and give it scrolling effect if text is too long to be displayed There has been a lot of bugs around some of the new logic with sliderMin and trying to get a transition to look nice on the slider by default. Hopefully I have found and fixed them all.
|
Thank Mate, you solved me long pending issue with my custom media card. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
my-button now support light, cover, switch, input_boolean, button, lock, media_player and blank entity.
my-slider-v2 media_player now has mode: 'seekbar' that will make the slider act as a seekbar for currently playing media.
my-slider-v2 new config key 'sliderMin'. This is a percentage that it should always show of the progress.
Lots and lots of bug fixes.
Related Issue
#52 Seekbar mode
Motivation and Context
Multiple changes to my-button to make it more versatile for more entity types as default.
The seekbar mode for the slider is nice. Thanks @sharn25 for the suggestion!
How Has This Been Tested
Extensively in my local setup. So far it seems to behave the same for me. There might be changes in peoples behavior if they were using transition on progress bar. There is some default transition now, and it will remove it when actively moving the slider to make it a smoother user experience.
Types of changes
Checklist