Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2 -> main ] Fix reported time for produced blocks and fix confusing reported time name #856

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Oct 1, 2024

Forwards #850

This PR

  • fixes incorrect reported time for "Produced blocks"
  • changes time for "Produced blocks" to producing time, and for "Received blocks" to applying time
  • adds time unit us to reported CPU time

Before the changes
info 2024-10-01T18:31:59.066 nodeos controller.cpp:3462 commit_block ] Produced block dd7794184632fdd2... #100 @ 2024-10-01T18:31:59.500 signed by eosio [trxs: 0, lib: 98, net: 0, cpu: 100, elapsed: 342 us, time: 1727797983669080 us]

After
info 2024-10-01T19:07:27.667 nodeos controller.cpp:3461 commit_block ] Produced block b29e040564b322f2... #100 @ 2024-10-01T19:07:28.000 signed by eosio [trxs: 0, lib: 98, net: 0, cpu: 100 us, elapsed: 291 us, producing time: 451393 us]

Fix #849

@linh2931 linh2931 merged commit d355d43 into main Oct 1, 2024
36 checks passed
@linh2931 linh2931 deleted the merge_fix_produced_time branch October 1, 2024 21:57
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Oct 1, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Logging
component: Internal
summary: Fix reported time for produced blocks and disambiguate time in logs.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time field for produced blocks is wrong and the name time is confusing with received block's time
4 participants