Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.1 -> main] Add unit tests to verify replay of blocks with bad QC data #766

Merged
merged 16 commits into from
Sep 12, 2024
Merged

[1.0.1 -> main] Add unit tests to verify replay of blocks with bad QC data #766

merged 16 commits into from
Sep 12, 2024

Conversation

linh2931
Copy link
Member

Forwards #759

Adds tests for QC validation during replay of blocks (implemented by #693).

Cases are tested:

  • Invalid QC claim (one that goes backward for example). Replay always fails.
  • Irrelevant QC (claims a block number other than the one claimed in the block header, or mismatching weak/strong claim). Replay always fails.
  • Bad QC (signature validation fails). Replay fails only if --force-all-checks is provided.

Resolves #727

linh2931 and others added 16 commits September 11, 2024 22:28
@linh2931
Add unit test to verify replay of blocks with bad QC data
d2f1aff
@linh2931
Refactor to have a common corrupt_finality_extension_in_block_log()
c013ee0
@linh2931
Verify exception thrown is exactly what to expected
cc46837
@linh2931
Merge branch 'release/1.0' into replay_block_invariants_tests
2de93d9
@linh2931
Fix use of signed_block_ptr due to newly changed definition of signed…
50eaede 
…_block_ptr
@linh2931
Test corrupted signature verification
973ab6e
@linh2931
Add more comments
081f9c5
@linh2931
Use a common fin_ext_id
3d31a30
@linh2931
remove through from through through in comments
e94ee70
@linh2931
Use config instead of chain.get_config()
d9f6faf
@linh2931
Use std::erase_if for deletion
3b18b8a
@linh2931
Add a comment
c840938
@linh2931
Use const controller::config&
601c7cc
@linh2931
More const controller::config&
3565374
@linh2931
Merge pull request #759 from AntelopeIO/replay_block_invariants_tests
c114fe5 
[1.0.1] Add unit tests to verify replay of blocks with bad QC data
@linh2931
Merge remote-tracking branch 'origin/release/1.0' into merge_replay_b…
4fd5d8a 
…lock_invariants_tests
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Add unit tests to verify replay of blocks with bad QC data.
Note:end

@linh2931 linh2931 merged commit eeec4ed into main Sep 12, 2024
36 checks passed
@linh2931 linh2931 deleted the merge_replay_block_invariants_tests branch September 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test to verify replay of blocks with bad QC data
5 participants
@linh2931 @ericpassmore @greg7mdp @heifner @arhag