Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.1 -> main] P2P: syncing fix #705

Merged
merged 7 commits into from
Sep 6, 2024
Merged

[1.0.1 -> main] P2P: syncing fix #705

merged 7 commits into from
Sep 6, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 5, 2024

Two small P2P syncing fixes:

  • Do not request next range of blocks if sync_last_requested_num is 0 as that case is handled in the first part of the if. If we do request a new range, request from a potentially different peer. Noticed that in practice it would often stick to its current peer here as this would be the first time it realized it needs a new range of blocks.
  • Update sync_active_time when a block is received. Noticed this "timer" was firing simply because it was taking too long to apply the blocks. I was testing with sync-fetch-span of 5000.
  • Normalize on using steady_clock for stopwatch functionality.

Merges release/1.0 into main including #671

Resolves #670

@heifner heifner added the OCI Work exclusive to OCI team label Sep 5, 2024
@heifner heifner merged commit 7ec1030 into main Sep 6, 2024
36 checks passed
@heifner heifner deleted the GH-670-p2p-sync-main branch September 6, 2024 13:58
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Plugins/Cleos/Utils
summary: Peer syncing fixes to improve active sync time, better normalizer timer, and skip unneeded request for additional blocks.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P syncing re-requesting ranges
4 participants