Fix test failures under default Savanna libtester #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setup_policy to eosio_system_tester constructor for more flexibility
…ar reference contracts and Spring dependency
This was
linked to
issues
May 29, 2024
heifner
approved these changes
May 30, 2024
.cicd/defaults.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "spring-dev":{ | |||
| "target":"main", | |||
| "target":"default_tester", | |||
There was a problem hiding this comment.
Remember to change back to main once merged.
There was a problem hiding this comment.
Thanks for the reminder.
|
Along with this PR you review and merge in PR #96 (picking up tokenomics changes). |
ericpassmore
approved these changes
May 30, 2024
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Default libtester changes to run under Savanna. This exposes several test failures. This PR addresses them:
eosio_bios_if_tests/set_1_finalizerfailures due to starting from Savanna tester (should have started from Legacy tester)eosio_system_tests/producer_wtmsig and eosio_system_tests/producer_wtmsig_transitionfailures due to proposer schedule algorithm changeeosio_system_tests/producer_onblock_checkfailures due to proposer schedule algorithm changeResolves
#90
#92
#93
Deployment Changes
API Changes
Documentation Additions