IF: switch variant index of new get_blocks_request_v1
#2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Apr 4, 2024
heifner
changed the title
get_blocks_request_v1get_blocks_request_v1
heifner
changed the title
get_blocks_request_v1get_blocks_request_v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of message types in the
state_requestvariant is part of the binary protocol. I suggest we add the newget_blocks_request_v1to the end. Otherwise, unmodified ship clients that both useget_blocks_ack_request_v0and do not consume the ABI from the websocket endpoint (I believe abieos or eos-go based readers) will misbehave.