IF: Clean up of bls_private_key, bls_public_key and bls_signature, …

libraries/libfc/include/fc/crypto/bls_private_key.hpp

@@ -37,6 +37,7 @@ namespace fc::crypto::blslib {
       private:
          std::array<uint64_t, 4> _sk;
 
+         friend bool operator == ( const bls_private_key& pk1, const bls_private_key& pk2);
          friend struct reflector<bls_private_key>;
    }; // bls_private_key
 

libraries/libfc/include/fc/crypto/bls_public_key.hpp

@@ -34,7 +34,6 @@ namespace fc::crypto::blslib {
          bls12_381::g1 _pkey;
 
       private:
-         friend std::ostream& operator<< (std::ostream& s, const bls_public_key& k);
          friend struct reflector<bls_public_key>;
          friend class bls_private_key;
    }; // bls_public_key

libraries/libfc/src/crypto/bls_private_key.cpp

@@ -49,6 +49,10 @@ namespace fc::crypto::blslib {
       return std::string(config::bls_private_key_prefix) + data_str;
    }
 
+   bool operator == ( const bls_private_key& pk1, const bls_private_key& pk2) {
+      return std::memcmp(&pk1, &pk2, sizeof(pk1)) == 0;
+   }
+
 } // fc::crypto::blslib
 
 namespace fc

libraries/libfc/src/crypto/bls_public_key.cpp

@@ -34,11 +34,6 @@ namespace fc::crypto::blslib {
 
    }
 
-   std::ostream& operator<<(std::ostream& s, const bls_public_key& k) {
-      s << "bls_public_key(" << k.to_string() << ')';
-      return s;
-   }
-
 } // fc::crypto::blslib
 
 namespace fc

libraries/libfc/src/crypto/bls_signature.cpp

@@ -39,11 +39,6 @@ namespace fc::crypto::blslib {
 
    }
 
-   std::ostream& operator<<(std::ostream& s, const bls_signature& k) {
-      s << "bls_signature(" << k.to_string() << ')';
-      return s;
-   }
-
    bool operator == ( const bls_signature& p1, const bls_signature& p2) {
 
       // until `bls12_381::g2` has an `operator==`, do binary comparison

libraries/libfc/test/test_bls.cpp

@@ -236,4 +236,22 @@ BOOST_AUTO_TEST_CASE(bls_pub_key_sig_serialization) try {
 
 } FC_LOG_AND_RETHROW();
 
+
+BOOST_AUTO_TEST_CASE(bls_cbinary_keys_encoding_check) try {
+
+  bls_private_key sk = bls_private_key(seed_1);
+
+  bool ok1 = bls_private_key(sk.to_string()) == sk;
+
+  std::string str =  sk.to_string();
+
+  bool ok2 = bls_private_key(str).to_string() == str;
+
+  BOOST_CHECK_EQUAL(ok1, true);
+  BOOST_CHECK_EQUAL(ok2, true);
+
+} FC_LOG_AND_RETHROW();
+
+
+
 BOOST_AUTO_TEST_SUITE_END()