fix leaky EOS VM OC executor code mapping #1499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executor
's ctor creates a shared mapping to the code cache file it is passed,leap/libraries/chain/webassembly/runtimes/eos-vm-oc/executor.cpp
Lines 146 to 151 in e9ace45
but its dtor doesn't unmap that mapping. That's sloppy and leaky. Easy enough to fix.
I'm not considering this for stable since realistically nodeos only ever creates one of these per thread for the entire lifetime of the application anyways.