Require dry-run trxs to have authorization and add tests #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Aug 14, 2023
greg7mdp
reviewed
Aug 14, 2023
| BOOST_REQUIRE_EQUAL(transaction_receipt::executed, trace->receipt->status); | ||
| // now push for real | ||
| trace = chain.push_transaction(trx); |
There was a problem hiding this comment.
We should probably check the status again after the real execution.
unittests/dry_run_trx_tests.cpp
Outdated
| getage_data = abi_ser.variant_to_binary("getage", mutable_variant_object() | ||
| ("user", "alice"), | ||
| abi_serializer::create_yield_function( abi_serializer_max_time )); | ||
| produce_block(); |
There was a problem hiding this comment.
Why do we call produce_block() here?
linh2931
reviewed
Aug 14, 2023
| send_db_api_transaction("insert"_n, insert_data, vector<permission_level>{{"alice"_n, config::active_name}}, transaction_metadata::trx_type::dry_run); | ||
|
|
||
| // verify the dry-run insert was rolled back, use a read-only trx to query | ||
| BOOST_CHECK_EXCEPTION(send_db_api_transaction("getage"_n, getage_data, {}, transaction_metadata::trx_type::read_only), fc::exception, |
There was a problem hiding this comment.
Like this combination of using read_only transaction.
linh2931
approved these changes
Aug 14, 2023
greg7mdp
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add requirement for dry-run/compute transactions to require authorization.
Add tests for dry-run/compute transactions.
Also some minor cleanup to unneeded includes.
Resolves #1083