Test Fix: Change default max-transaction-cpu-usage for tests #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance tests to 475ms
oschwaldp-oci
approved these changes
Jul 21, 2023
greg7mdp
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default genesis
max_transaction_cpu_usagefrom 150ms to 475ms to allow for slow ci/cd. All the integration tests already used 475ms formax_transaction_cpu_usage. This PR changes the performance tests to use the same value. Also changedmax_block_cpu_usagefrom 200ms to 500ms since it has to be larger thanmax_transaction_cpu_usage. This also matches the value used for integration tests.Note #1401 was not sufficient because the value in the performance
genesis.jsonwas being overwritten bylauncher.py.Resolves #1416