Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Memory issue fix #1392

Closed
wants to merge 3 commits into from
Closed

[3.1] Memory issue fix #1392

wants to merge 3 commits into from

Conversation

linh2931
Copy link
Member

This PR contains security updates to fix a denial of service vulnerability affecting all previous versions of Leap.

Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have expected the version bump in a diff PR.

@linh2931
Copy link
Member Author

Would have expected the version bump in a diff PR.

Should I redo this? Or keep as is, but for 3.2 and 4.0, the version bump is in a different PR?

@heifner
Copy link
Member

heifner commented Jul 12, 2023

Would have expected the version bump in a diff PR.

Should I redo this? Or keep as is, but for 3.2 and 4.0, the version bump is in a different PR?

I don't think it is a huge deal either way. But in general I think it better to keep it as a diff PR.

@linh2931
Copy link
Member Author

I don't think it is a huge deal either way. But in general I think it better to keep it as a diff PR.

I think I should redo it so to make the history trail cleaner. I am closing this PR and starting a new one. Thanks.

@linh2931 linh2931 closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants