[4.0] SHiP: Support snapshot start with full deltas #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…immediately after loading a snapshot
… blocks applied. Also do not repeatable send empty get_blocks_response messages but rather start sending first available block data.
greg7mdp
reviewed
Jul 6, 2023
plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp
Show resolved
Hide resolved
greg7mdp
approved these changes
Jul 6, 2023
linh2931
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
state_history_pluginclients when starting from snapshot. Allow clients to connect and receive full delta of a snapshot without consuming any additional blocks.Does not send
get_block_result_v0messages for requested blocks that are not available. Previously it would sendget_blocks_result_v0with emptythis_blockrepeatably. Instead SHiP will send first available block that is available within requested range or wait for request block to become available to send to client.Resolves #1340