Make sure all exceptions are caught when executing code in http_plugin's thread pool, so Leap doesn't crash when processing APIs. #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
changed the title
http_fwd();
|
please update resolving issue to #1372 |
|
OK, I have added the test. It passes with this PR, but without the change in macros.hpp, it fails as shown in the image below: |
heifner
approved these changes
Jul 27, 2023
linh2931
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1372
Make sure all exceptions are caught when executing code in http_plugin's thread pool.
Add section in
tests/nodeos_run_test.pyto verify that an exception when processing the tail end ofget_table_rowin the http thread pool is caught and doesn't kill nodeos.Also removed duplicated test (same test run twice) in
tests/CMakeLists.txt