Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failure: performance_test_basic_read_only_trxs #1416

Closed
heifner opened this issue Jul 19, 2023 · 3 comments · Fixed by #1436
Closed

Test Failure: performance_test_basic_read_only_trxs #1416

heifner opened this issue Jul 19, 2023 · 3 comments · Fixed by #1436
Assignees
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Jul 19, 2023

https://github.com/AntelopeIO/leap/actions/runs/5602344355/jobs/10247564180

Set of system contract failing: cmd: /__w/leap/leap/build/bin/cleos --url http://localhost:8788 --wallet-url http://localhost:9899 --no-auto-keosd -v set contract -j eosio /__w/leap/leap/build/unittests/contracts/eosio.system eosio.system.wasm eosio.system.abi

The genesis.json is using 150ms for max_transaction_cpu_usage even though the tests/performance_tests/genesis.json has the value of 475ms. The value apparently is being overwritten to 150ms somewhere.

Looks like here: cfg.add_argument('--max-transaction-cpu-usage', type=int, help='the "max-transaction-cpu-usage" value to use in the genesis.json file', default=150000) in launcher.py.

@heifner heifner added the bug Something isn't working label Jul 19, 2023
@bhazzard bhazzard added 👍 lgtm and removed triage labels Jul 19, 2023
@heifner
Copy link
Member Author

heifner commented Jul 20, 2023

Note this was not enough: #1401 because of the default provided by launcher.py.

@heifner
Copy link
Member Author

heifner commented Jul 20, 2023

@greg7mdp
Copy link
Contributor

Looks like here: cfg.add_argument('--max-transaction-cpu-usage', type=int, help='the "max-transaction-cpu-usage" value to use in the genesis.json file', default=150000) in launcher.py.

Hum, not sure, even if I change this value from 150,000 to 10,000 the test still succeeds when I run it locally.

@heifner heifner self-assigned this Jul 20, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jul 20, 2023
heifner added a commit that referenced this issue Jul 21, 2023
heifner added a commit that referenced this issue Jul 21, 2023
heifner added a commit that referenced this issue Jul 21, 2023
heifner added a commit that referenced this issue Jul 22, 2023
Test Fix: Change default max-transaction-cpu-usage for tests
@BenjaminGormanPMP BenjaminGormanPMP modified the milestone: Leap v5.0.1 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants