GH-1541 minor cleanup

AntelopeIO · Aug 28, 2023 · a7fc539 · a7fc539
1 parent cb8bc49
commit a7fc539
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/libraries/chain/include/eosio/chain/finalizer_set.hpp b/libraries/chain/include/eosio/chain/finalizer_set.hpp
@@ -100,7 +100,7 @@ namespace eosio::chain {
       }
 
       uint32_t                                       version = 0; ///< sequentially incrementing version number
-      uint64_t                                       fthreshold;  // vote fweight threshold to finalize blocks
+      uint64_t                                       fthreshold = 0;  // vote fweight threshold to finalize blocks
       vector<finalizer_authority>                    finalizers; // Instant Finality voter set
 
       friend bool operator == ( const finalizer_set& a, const finalizer_set& b )

diff --git a/libraries/hotstuff/chain_pacemaker.cpp b/libraries/hotstuff/chain_pacemaker.cpp
@@ -204,6 +204,7 @@ namespace eosio { namespace hotstuff {
    void chain_pacemaker::on_accepted_block( const block_state_ptr& blk ) {
       std::scoped_lock g( _chain_state_mutex );
       _head_block_state = blk;
+      // TODO only update local cache if changed, check version or use !=
       _finalizer_set = _chain->get_finalizers(); // TODO get from chainbase or from block_state
    }
 
@@ -253,9 +254,11 @@ namespace eosio { namespace hotstuff {
       //
       std::unique_lock g( _chain_state_mutex );
       const auto& fin_set = _chain->get_finalizers(); // TODO use
+      block_state_ptr hbs = _head_block_state;
+      g.unlock();
 
       // Old code: get eosio::name from the producer schedule
-      const std::vector<producer_authority>& pa_list = _head_block_state->active_schedule.producers;
+      const std::vector<producer_authority>& pa_list = hbs->active_schedule.producers;
       std::vector<name> pn_list;
       pn_list.reserve(pa_list.size());
       std::transform(pa_list.begin(), pa_list.end(),