deleted #161
Closed
deleted #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR - but it looks like this is a duplicate of #160. |
|
I'm not sure how this happened?
In my VSCode, it shows the correct code, but the commit shows a different
code, let me do something about it. I have made some minor changes to
commit it again.
Also, I can see that PR #161 has the correct commit.
Please check commit *b13169eb4c7a502e8f7b0e96274c1380d1a9a634a* (yesterday)
and *b54597ba7014e2deaa917f033999fa3865ae33ce* (today). Hope this works
from your end too!
Please do let me know if there are any concerns
Best,
Nidhi
…On Tue, Jul 9, 2024 at 2:08 PM Ann Marie Ward ***@***.***> wrote:
Hi @nidhikamath2102 <https://github.com/nidhikamath2102>
Thanks for this PR - but it looks like this is a duplicate of #160
<#160>.
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQIM4GZXT7X6NDR2HNKB3LZLQRIFAVCNFSM6AAAAABKSBPA5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGM2DGNBXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I'm not sure what's going on, but sometimes it gets confusing to have two open PRs. Now both PRs have both app. Let's go ahead an close this one and finish the 160 first. |
|
Works.
…On Tue, Jul 9, 2024 at 3:15 PM Ann Marie Ward ***@***.***> wrote:
I'm not sure what's going on, but sometimes it gets confusing to have two
open PRs. Now both PRs have both app. Let's go ahead an close this one and
finish the 160 first.
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQIM4EVMCJO7KN3BRC5DUTZLQZFNAVCNFSM6AAAAABKSBPA5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGQ2TQOBUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2) Removed dbc component and replaced it with html. 3) Set clearable=False in the dropdown and cleaned up relevant code for select a plot type. 4) Increased sleep time duration from 0.25 to 1 s to simulate longer running callback.
|
Hi,
I have made the changes. Please check and let me know.
1) Fixed errors on the console.
2) Removed dbc component and replaced it with html.
3) Set clearable=False in the dropdown and cleaned up relevant code for
select a plot type.
4) Increased sleep time duration from 0.25 to 1 s to simulate longer
running callback.
There is no specific reason to use 2 date pickers instead of 1 single date
picker range. It just looked better to have it in the UI, hence kept it.
Let me know if this works!
Best,
Nidhi
…On Tue, Jul 9, 2024 at 4:15 PM Nidhi Kamath ***@***.***> wrote:
Works.
On Tue, Jul 9, 2024 at 3:15 PM Ann Marie Ward ***@***.***>
wrote:
> I'm not sure what's going on, but sometimes it gets confusing to have two
> open PRs. Now both PRs have both app. Let's go ahead an close this one and
> finish the 160 first.
>
> —
> Reply to this email directly, view it on GitHub
> <#161 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMQIM4EVMCJO7KN3BRC5DUTZLQZFNAVCNFSM6AAAAABKSBPA5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGQ2TQOBUGI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have created a pull request for the custom_spinner example. Kindly check this and let me know if any changes are needed.