fix: Crash when there is a compute-type node label but it isnt fargate

AndreZiviani · Mar 18, 2023 · a7e9a0f · a7e9a0f
1 parent 3b58735
commit a7e9a0f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/exporter/kubernetes.go b/exporter/kubernetes.go
@@ -219,12 +219,12 @@ func (m *Metrics) nodeCreated(obj interface{}) {
 		Region: node.ObjectMeta.Labels["topology.kubernetes.io/region"],
 	}
 
-	if _, ok := node.Labels["eks.amazonaws.com/compute-type"]; ok {
+	if _, ok := node.ObjectMeta.Labels["node.kubernetes.io/instance-type"]; ok {
+		tmp.Instance = m.Instances[node.ObjectMeta.Labels["node.kubernetes.io/instance-type"]]
+	} else if _, ok := node.Labels["eks.amazonaws.com/compute-type"]; ok {
 		if node.Labels["eks.amazonaws.com/compute-type"] == "fargate" {
 			tmp.Instance = m.Instances["fargate"]
 		}
-	} else if _, ok := node.ObjectMeta.Labels["node.kubernetes.io/instance-type"]; ok {
-		tmp.Instance = m.Instances[node.ObjectMeta.Labels["node.kubernetes.io/instance-type"]]
 	}
 
 	m.nodesMtx.Lock()