Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support start/end timezones for Google provider #609

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

guillenotfound
Copy link

@guillenotfound guillenotfound commented Aug 27, 2024

image

Additionally I did some minor formatting but we can discard that if you don't like it.

Off topic:

  • Generally speaking I think it would make sense to use types over interfaces
  • I don't think there should be a snapshot for providers which doesn't support an specific functionality
  • start & end should have more restrictive types on a type level (even if that doesn't make any difference)
  • Is there any reason not to use URL and any other related constructors to replace stringify fn?

@AnandChowdhary
Copy link
Owner

Thank you for your hard work on this, really appreciate it! Does it make sense to rename the variables startTimeZone and endTimeZone to make it clearer, what do you think?

@guillenotfound
Copy link
Author

Sorry @AnandChowdhary , missed the notification. Updated as per your suggestion 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants