Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: barista perks #413

Merged
merged 71 commits into from
Nov 9, 2023
Merged

feat: barista perks #413

merged 71 commits into from
Nov 9, 2023

Conversation

fredpetersen
Copy link
Contributor

@fredpetersen fredpetersen commented Mar 28, 2023

Closes #422

Visual: A new section has been added to the tickets page, that shows your perks if your user is registered as Barista+

All purchaseable products are now loaded in the SplashRouter which has now been renamed to MainRedirectionRouter (These products are now also fetched from ProductsControllerV2 instead of V1)

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (1def5db) 74.18% compared to head (8df17d8) 72.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   74.18%   72.87%   -1.31%     
==========================================
  Files         128      130       +2     
  Lines        1534     1567      +33     
==========================================
+ Hits         1138     1142       +4     
- Misses        396      425      +29     
Flag Coverage Δ
unittests 72.87% <64.28%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t/data/datasources/product_remote_data_source.dart 100.00% <100.00%> (ø)
...ib/features/product/data/models/product_model.dart 100.00% <100.00%> (ø)
lib/features/product/domain/entities/product.dart 100.00% <100.00%> (ø)
...ures/product/domain/usecases/get_all_products.dart 100.00% <100.00%> (ø)
...ures/product/presentation/cubit/product_cubit.dart 100.00% <100.00%> (ø)
...ures/product/presentation/cubit/product_state.dart 100.00% <100.00%> (ø)
...et/data/datasources/ticket_remote_data_source.dart 100.00% <100.00%> (+9.52%) ⬆️
...tures/ticket/presentation/cubit/tickets_cubit.dart 100.00% <100.00%> (ø)
...tures/ticket/presentation/cubit/tickets_state.dart 100.00% <100.00%> (ø)
lib/features/user/domain/entities/user.dart 62.06% <100.00%> (+9.89%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented May 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ghost

This comment was marked as off-topic.

@fredpetersen fredpetersen marked this pull request as ready for review November 9, 2023 16:15
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marfavi marfavi enabled auto-merge (squash) November 9, 2023 19:02
marfavi
marfavi previously approved these changes Nov 9, 2023
@marfavi marfavi merged commit 8d8825d into main Nov 9, 2023
8 of 10 checks passed
@marfavi marfavi deleted the frepe/barista-hub branch November 9, 2023 19:24
@fremartini fremartini mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a permanent solution to getting barista products
3 participants